• onlinepersona@programming.dev
    link
    fedilink
    English
    arrow-up
    6
    arrow-down
    2
    ·
    1 year ago

    So there’s really only a benefit if you don’t use squash and bother with maintaining proper commit messages in your PRs

    I’d argue that you should never squash and always maintain proper commit messages…

      • Kevin Lyda@programming.dev
        link
        fedilink
        English
        arrow-up
        2
        ·
        1 year ago

        I have never heard proper reasoning for squashing commits. I don’t think sanitized history is useful in any context. Seeing the thought process that went into building something has been repeatedly useful in debugging things. It’s also useful to me as a software engineering manager to help folks on my team get better. I could care less how “pretty” git log looks, but I care a hell of a lot about what git diff and git blame tell me. They help me figure out where issues actually are and how they came to be.